Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The signal is not rescaled before applying some transformations #184

Closed
antoinecarme opened this issue Mar 9, 2022 · 0 comments · Fixed by #189
Closed

The signal is not rescaled before applying some transformations #184

antoinecarme opened this issue Mar 9, 2022 · 0 comments · Fixed by #189
Assignees
@antoinecarme
Labels
class:bug priority:high topic:modeling_quality topic:signal_transformation

Comments

@antoinecarme
Copy link
Owner

The signal transformations need to be applied in a uniform way. the signal is first re-scaled to be in the [0, 1] range , transformations are applied after the re-scaling. This is not the case today.

Force re-scaling for all transformations. This will not change PyAF behavior/training a lot as the re-scaling is a linear operation.

Target Release : 2022-07-14
antoinecarme added a commit that referenced this issue Mar 9, 2022
@antoinecarme
The signal is not rescaled before applying some transfromations #184
1f2da00 
Force rescaling the signals for all tranmsfromations.
Robustfied some computations.
antoinecarme added a commit that referenced this issue Mar 9, 2022
@antoinecarme
The signal is not rescaled before applying some transfromations #184
1acc53f 
Added a notebook to test and plot all signal transformation results.
antoinecarme added a commit that referenced this issue Mar 9, 2022
@antoinecarme
The signal is not rescaled before applying some transfromations #184
9c3be1f 
Added some tests
@antoinecarme antoinecarme mentioned this issue Mar 9, 2022
Merged
@antoinecarme antoinecarme mentioned this issue Mar 19, 2022
Closed
@antoinecarme antoinecarme changed the title The signal is not rescaled before applying some transfromations The signal is not rescaled before applying some transformations May 10, 2022
@antoinecarme antoinecarme self-assigned this May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoinecarme antoinecarme

Labels
class:bug priority:high topic:modeling_quality topic:signal_transformation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transformation tests antoinecarme/pyaf
1 participant
@antoinecarme