From 69c2c21a55bae473f30b4eb48293f6287c2d49af Mon Sep 17 00:00:00 2001
From: Antoine Zanardi <antoine.zanardi@epitech.eu>
Date: Sun, 8 Sep 2024 10:06:48 +0200
Subject: [PATCH] fix(pwa): remove redirect fallback (#830)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced caching capabilities by including `json` and `woff2` file
types in the service worker's precaching strategy.
- Introduced a new property to manage navigation requests, improving
routing control.

- **Improvements**
- Development server now runs on port 4000, allowing for more controlled
access during development.

- **Bug Fixes**
- Streamlined acceptance test for the Game Lobby Options Hub by removing
unnecessary user action, improving test efficiency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 nuxt.config.ts                                |  5 +-
 package.json                                  |  2 +-
 public/favicons/site.webmanifest              | 46 -------------------
 .../game-lobby-options-hub.feature            |  1 -
 4 files changed, 4 insertions(+), 50 deletions(-)
 delete mode 100644 public/favicons/site.webmanifest

diff --git a/nuxt.config.ts b/nuxt.config.ts
index 5453dcbc1d0..faf2195a72f 100644
--- a/nuxt.config.ts
+++ b/nuxt.config.ts
@@ -172,10 +172,11 @@ export default defineNuxtConfig({
       periodicSyncForUpdates: 86400,
     },
     workbox: {
-      globPatterns: ["**/*.{js,css,html,png,svg,ico}"],
+      globPatterns: ["**/*.{js,css,html,png,svg,ico,json,woff2}"],
+      navigateFallbackDenylist: [/^.*$/u],
     },
     injectManifest: {
-      globPatterns: ["**/*.{js,css,html,png,svg,ico}"],
+      globPatterns: ["**/*.{js,css,html,png,svg,ico,json,woff2}"],
     },
     manifest: {
       name: process.env.NUXT_SITE_NAME,
diff --git a/package.json b/package.json
index 29c86c530e7..c52f347e36d 100644
--- a/package.json
+++ b/package.json
@@ -31,7 +31,7 @@
     "start:prod": "node .output/server/index.mjs",
     "prepare": "is-ci || husky",
     "build": "nuxt build",
-    "dev": "nuxt dev --dotenv env/.env.development",
+    "dev": "nuxt dev --dotenv env/.env.development --port 4000",
     "generate": "nuxt generate",
     "preview": "npm run build && nuxt preview --dotenv env/.env.production",
     "postinstall": "! ls -log -u node_modules/.bin/nuxt || nuxt prepare",
diff --git a/public/favicons/site.webmanifest b/public/favicons/site.webmanifest
deleted file mode 100644
index 1c10676e1e1..00000000000
--- a/public/favicons/site.webmanifest
+++ /dev/null
@@ -1,46 +0,0 @@
-{
-  "name": "Your App Name",
-  "short_name": "AppName",
-  "description": "A brief description of your app",
-  "icons": [
-    {
-      "src": "/favicons/android-chrome-192x192.png",
-      "sizes": "192x192",
-      "type": "image/png"
-    },
-    {
-      "src": "/favicons/android-chrome-256x256.png",
-      "sizes": "256x256",
-      "type": "image/png"
-    },
-    {
-      "src": "/favicons/apple-touch-icon.png",
-      "sizes": "180x180",
-      "type": "image/png"
-    },
-    {
-      "src": "/favicons/favicon-16x16.png",
-      "sizes": "16x16",
-      "type": "image/png"
-    },
-    {
-      "src": "/favicons/favicon-32x32.png",
-      "sizes": "32x32",
-      "type": "image/png"
-    },
-    {
-      "src": "/favicons/mstile-150x150.png",
-      "sizes": "150x150",
-      "type": "image/png"
-    },
-    {
-      "src": "/favicons/favicon.png",
-      "sizes": "192x192",
-      "type": "image/png"
-    }
-  ],
-  "start_url": "/",
-  "display": "standalone",
-  "background_color": "#ffffff",
-  "theme_color": "#ffffff"
-}
\ No newline at end of file
diff --git a/tests/acceptance/features/game-lobby/features/game-lobby-options-hub/game-lobby-options-hub.feature b/tests/acceptance/features/game-lobby/features/game-lobby-options-hub/game-lobby-options-hub.feature
index 8627dc26333..65b4e347423 100644
--- a/tests/acceptance/features/game-lobby/features/game-lobby-options-hub/game-lobby-options-hub.feature
+++ b/tests/acceptance/features/game-lobby/features/game-lobby-options-hub/game-lobby-options-hub.feature
@@ -26,7 +26,6 @@ Feature: ⚙️ Game Lobby Options Hub
     And the user disables the sheriff in game options
 
     When the user reloads the page
-    And the user clicks on the link with name "Play"
     And the user clicks on the game options button in the lobby
     Then the heading with name "Game options" should be visible
     And the exact text "The game will not have a Sheriff." should be visible