Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bin): Remove kt #461

Merged
merged 3 commits into from
Aug 27, 2024
Merged

chore(bin): Remove kt #461

merged 3 commits into from
Aug 27, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Aug 27, 2024

Overview

Removes the kt binary from kona. We are pivoting a bit to a different test format. This tool may return in the future, but for now, is just adding extra compile time etc.

@clabby clabby added the K-chore Kind: chore label Aug 27, 2024
@clabby clabby self-assigned this Aug 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.3%. Comparing base (edd7081) to head (37f3fcb).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell
Copy link
Collaborator

refcell commented Aug 27, 2024

RIP ethereum-optimism/tests you were magnificent while you lasted. A true steward of testing. A lone vector in the night.

@clabby clabby added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit df189a2 Aug 27, 2024
14 checks passed
clabby added a commit that referenced this pull request Aug 27, 2024
* chore(bin): Remove `kt`

* lint

* lint
github-merge-queue bot pushed a commit that referenced this pull request Aug 27, 2024
* fix: downgrade for release plz (#458)

* chore(bin): Remove `kt` (#461)

* chore(bin): Remove `kt`

* lint

* lint

* fix(client): walkback channel timeout

* update tests

* lint

---------

Co-authored-by: clabby <ben@clab.by>
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants