Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(derive): Sequence window expiry #532

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix(derive): Sequence window expiry #532

merged 2 commits into from
Sep 17, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Sep 17, 2024

Overview

Fixes sequence window expiry in kona-derive. Previously it was checking the wrong L1 origin to decide whether or not force_empty_batches was active.

Copy link
Collaborator Author

clabby commented Sep 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby force-pushed the cl/fix-sequence-window branch from 2234a5e to 1fb9a30 Compare September 17, 2024 18:33
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.9%. Comparing base (a5d37b0) to head (1fb9a30).
Report is 1 commits behind head on main.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find

@clabby clabby added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 2f57beb Sep 17, 2024
16 checks passed
@github-actions github-actions bot mentioned this pull request Sep 17, 2024
@clabby clabby deleted the cl/fix-sequence-window branch September 17, 2024 18:52
This was referenced Sep 21, 2024
This was referenced Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants