Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(executor): Use Upstreamed op-alloy Methods #651

Merged
merged 4 commits into from
Oct 9, 2024
Merged

chore(executor): Use Upstreamed op-alloy Methods #651

merged 4 commits into from
Oct 9, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Oct 8, 2024

Description

Cleans up op-alloy type use and custom functions that are upstreamed.

@refcell refcell added K-chore Kind: chore A-executor Area: kona-executor crate labels Oct 8, 2024
@refcell refcell self-assigned this Oct 8, 2024
@refcell refcell added the M-patch Meta: Contains crates-io patches label Oct 8, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.4%. Comparing base (d3f8045) to head (62b418a).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/executor/src/lib.rs 90.9% 1 Missing ⚠️
crates/executor/src/util.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell marked this pull request as ready for review October 9, 2024 16:29
@refcell refcell requested a review from clabby as a code owner October 9, 2024 16:29
@refcell refcell force-pushed the rf/chore/use-upstream-sys-tx-method branch from 71e725d to 7b06e26 Compare October 9, 2024 16:33
clabby
clabby requested changes Oct 9, 2024
View reviewed changes
crates/executor/src/util.rs Outdated Show resolved Hide resolved
@refcell refcell requested a review from clabby October 9, 2024 17:14
@clabby clabby added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 98f9337 Oct 9, 2024
17 checks passed
This was referenced Oct 9, 2024
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
A-executor Area: kona-executor crate K-chore Kind: chore M-patch Meta: Contains crates-io patches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @clabby