feat(derive): Past batch validity variant
#684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
clabby
force-pushed
the
cl/batch-validity-fix
branch
from
ba4f3df to
b245c70
Compare
clabby
force-pushed
the
cl/batch-validity-fix
branch
from
b245c70 to
5225b43
Compare
sebastianst
reviewed
Oct 10, 2024
clabby
force-pushed
the
cl/batch-validity-fix
branch
from
118593a to
5225b43
Compare
clabby
changed the title
BatchOutdated validity variantPast batch validity variant
refcell
approved these changes
Oct 10, 2024
|
This LGTM - rip coverage |
refcell
pushed a commit
that referenced
this pull request
Oct 18, 2024
* feat(derive): `BatchOutdated` validity variant * `BatchValidity::Past` * log rename
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a new variant to the
BatchValidityenum that activates with Holocene. When a batch is outdated, after Holocene, thePastvariant is returned. In theBatchQueue, this instructs a silent drop, without flushing the active span batch and channel.We should follow this PR up with removing the additional check within
add_batch, deferring to the validity checks inderive_next_batch.