Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(derive): Holocene SpanBatch prefix checks #688

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Oct 13, 2024

Overview

Fixes the Holocene span batch prefix checks by using the l1 inclusion timestamp over the batch timestamp. This matters because first channel after Holocene may have some batches pre-Holocene and some batches after. h/t @sebastianst

think about the first channel after Holocene activation. Its first batches will have a batch timestamp pre-Holocene, so the new rules wouldn't be applied to those, and worst case the validation would return e.g. a BatchFuture validity, which gets removed with Holocene. So I'm afraid we do have to activate those rules by l1 inclusion block timestamp.

Also, de-duplicates some code by re-using the check_batch_prefix function in SpanBatch::check_batch.

@clabby clabby added A-derive Area: kona-derive crate K-fix Kind: fix labels Oct 13, 2024
@clabby clabby self-assigned this Oct 13, 2024
@clabby clabby force-pushed the cl/fix-prefix-check-edge branch from 8843b2c to 98c7bfa Compare October 13, 2024 03:52
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.0%. Comparing base (38cf22e) to head (04b933c).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/batch/span_batch/batch.rs 95.1% 4 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby added the H-holocene Hardfork: Holocene related label Oct 13, 2024
@clabby clabby marked this pull request as ready for review October 13, 2024 17:42
@clabby clabby requested a review from refcell as a code owner October 13, 2024 17:42
@refcell refcell added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 3e21875 Oct 14, 2024
17 checks passed
@github-actions github-actions bot mentioned this pull request Oct 14, 2024
refcell pushed a commit that referenced this pull request Oct 18, 2024
* fix(derive): Holocene `SpanBatch` prefix checks

* simplify

* lint
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
fakedev9999 pushed a commit to fakedev9999/kona that referenced this pull request Nov 5, 2024
* fix(derive): Holocene `SpanBatch` prefix checks

* simplify

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate H-holocene Hardfork: Holocene related K-fix Kind: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants