fix(derive): Holocene SpanBatch
prefix checks
#688
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the Holocene span batch prefix checks by using the l1 inclusion timestamp over the batch timestamp. This matters because first channel after Holocene may have some batches pre-Holocene and some batches after. h/t @sebastianst
Also, de-duplicates some code by re-using the
check_batch_prefix
function inSpanBatch::check_batch
.