Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(executor): EIP-1559 configurability spec updates #716

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Oct 19, 2024

Overview

Updates kona-executor to be in-line with the new spec, using extraData rather than nonce to store the EIP-1559 parameters post-holocene.

ref spec: here

closes #697

@clabby clabby added K-feature Kind: feature A-executor Area: kona-executor crate H-holocene Hardfork: Holocene related labels Oct 19, 2024
@clabby clabby self-assigned this Oct 19, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 96.20253% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@7d22a13). Learn more about missing BASE report.
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/executor/src/lib.rs 75.0% 6 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby marked this pull request as ready for review October 19, 2024 05:51
@clabby clabby requested a review from refcell as a code owner October 19, 2024 05:51
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@refcell refcell added this pull request to the merge queue Oct 19, 2024
Merged via the queue into main with commit fe1e341 Oct 19, 2024
17 checks passed
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
fakedev9999 pushed a commit to fakedev9999/kona that referenced this pull request Nov 5, 2024
* feat(executor): EIP-1559 configurability spec updates

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-executor Area: kona-executor crate H-holocene Hardfork: Holocene related K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(executor): Configurable EIP-1559 Parameter Updates
2 participants