Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(derive): Error Exports #758

Merged
merged 4 commits into from
Oct 30, 2024
Merged

chore(derive): Error Exports #758

merged 4 commits into from
Oct 30, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Oct 30, 2024

Description

Small PR to clean up error types and re-exports in kona-derive.

@refcell refcell requested a review from clabby as a code owner October 30, 2024 16:25
@refcell
Copy link
Collaborator Author

refcell commented Oct 30, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell self-assigned this Oct 30, 2024
@refcell refcell added K-chore Kind: chore A-derive Area: kona-derive crate labels Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@a862a4b). Learn more about missing BASE report.
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/errors/sources.rs 0.0% 3 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell changed the base branch from rf/cean-exports to main October 30, 2024 20:40
@refcell refcell enabled auto-merge October 30, 2024 20:42
@refcell refcell added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit c541bac Oct 30, 2024
16 checks passed
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
fakedev9999 pushed a commit to fakedev9999/kona that referenced this pull request Nov 5, 2024
* feat: clean exports

* fix: lints

* feat: error re-exports

* touchups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants