Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(derive): From<BlobProviderError> for PipelineErrorKind #780

Merged
merged 2 commits into from
Nov 5, 2024
Merged

feat(derive): From<BlobProviderError> for PipelineErrorKind #780

merged 2 commits into from
Nov 5, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Nov 4, 2024

Overview

Enforces that the BlobProvider trait impls use an Error type that can be converted to PipelineErrorKind.

@clabby clabby requested a review from refcell as a code owner November 4, 2024 23:49
@clabby clabby added A-derive Area: kona-derive crate A-derive-alloy K-feature Kind: feature labels Nov 4, 2024
@clabby clabby self-assigned this Nov 4, 2024
@clabby
Copy link
Collaborator Author

clabby commented Nov 4, 2024 •
edited
Loading

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@clabby clabby mentioned this pull request Nov 4, 2024
Merged
@clabby clabby force-pushed the cl/blob-provider-into-pl branch from cfe4458 to 26fce0e Compare November 4, 2024 23:54
@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.6%. Comparing base (a6ef5ab) to head (05aa457).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/errors/sources.rs 57.1% 3 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

refcell
refcell approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@clabby clabby changed the base branch from cl/client-anyhow-del to main November 5, 2024 00:25
@clabby clabby force-pushed the cl/blob-provider-into-pl branch from 26fce0e to 05aa457 Compare November 5, 2024 00:25
@clabby clabby enabled auto-merge November 5, 2024 00:25
@clabby clabby added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit ac96fc2 Nov 5, 2024
15 of 16 checks passed
@clabby clabby deleted the cl/blob-provider-into-pl branch November 5, 2024 00:31
@github-actions github-actions bot mentioned this pull request Nov 5, 2024
Merged
fakedev9999 pushed a commit to fakedev9999/kona that referenced this pull request Nov 5, 2024
@clabby
feat(derive): From<BlobProviderError> for PipelineErrorKind (op-rs#780
a145c81 
)

* feat(derive): `From<BlobProviderError> for PipelineErrorKind`

* lint

lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

Assignees

@clabby clabby

Labels
A-derive Area: kona-derive crate K-feature Kind: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clabby @refcell