Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(driver,client): Pipeline Cursor Refactor #798

Merged
merged 2 commits into from
Nov 11, 2024
Merged

feat(driver,client): Pipeline Cursor Refactor #798

merged 2 commits into from
Nov 11, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Nov 8, 2024

Description

Refactors the SyncStart into a new PipelineCursor that tracks the state of the driver.

@refcell refcell added K-feature Kind: feature A-client Area: client binary labels Nov 8, 2024
@refcell refcell self-assigned this Nov 8, 2024
@refcell refcell requested a review from clabby as a code owner November 8, 2024 19:21
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 74 lines in your changes missing coverage. Please review.

Project coverage is 91.3%. Comparing base (5d14375) to head (17c81fc).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/driver/src/cursor.rs 0.0% 50 Missing ⚠️
crates/driver/src/tip.rs 0.0% 16 Missing ⚠️
crates/driver/src/core.rs 0.0% 8 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell force-pushed the rf/fix/sync-start-refactor branch from 6e516ce to af9bd62 Compare November 11, 2024 00:15
@refcell refcell force-pushed the rf/feat/pipeline-cursor branch from 94f4510 to d1f0090 Compare November 11, 2024 01:25
@refcell refcell changed the base branch from rf/fix/sync-start-refactor to main November 11, 2024 01:25
@refcell refcell added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 2e943f4 Nov 11, 2024
15 of 16 checks passed
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
Closed
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
A-client Area: client binary K-feature Kind: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @clabby