Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workspace): Migrate back to thiserror v2 #811

Merged
merged 3 commits into from
Nov 13, 2024
Merged

chore(workspace): Migrate back to thiserror v2 #811

merged 3 commits into from
Nov 13, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Nov 13, 2024

Overview

Migrates all crates back to thiserror, now that >=v2.0.0 has support for no_std with default-features = false.

closes #806

@clabby clabby requested a review from refcell as a code owner November 13, 2024 16:36
@clabby clabby added A-workspace Area: Top level workspace modifications F-deps Flag: Updates dependencies K-chore Kind: chore labels Nov 13, 2024
@clabby clabby self-assigned this Nov 13, 2024
@clabby
Copy link
Collaborator Author

clabby commented Nov 13, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.8%. Comparing base (90552f1) to head (4421195).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/mpt/src/node.rs 0.0% 3 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice mr allen

@clabby clabby enabled auto-merge November 13, 2024 17:09
@clabby clabby added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 979c663 Nov 13, 2024
15 of 16 checks passed
This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-workspace Area: Top level workspace modifications F-deps Flag: Updates dependencies K-chore Kind: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Replace Custom error impls with thiserror
2 participants