Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace): Isolate FPVM-specific platform code #821

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Nov 15, 2024

Overview

Isolates the FPVM-specific platform code into separate crates. This solves the issues that zkVM teams are having with the kona-client libs being coupled to the kona-common IO pattern.

This PR will be followed up with a new kona-client library, that just serves the entrypoint, generic over the communication Channel. From there, we can run kona-client in the host w/ tokio channels in the same process, and reuse the same logic for the entry point with a kona-std-fpvm::FileChannel

@clabby clabby requested a review from refcell as a code owner November 15, 2024 23:10
@clabby clabby added A-workspace Area: Top level workspace modifications K-feature Kind: feature labels Nov 15, 2024
@clabby clabby self-assigned this Nov 15, 2024
@clabby
Copy link
Collaborator Author

clabby commented Nov 15, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 22.77228% with 78 lines in your changes missing coverage. Please review.

Project coverage is 90.6%. Comparing base (657d313) to head (2b96a72).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/proof-sdk/std-fpvm/src/tracing.rs 0.0% 34 Missing ⚠️
crates/proof-sdk/std-fpvm/src/io.rs 0.0% 30 Missing ⚠️
crates/proof-sdk/std-fpvm/src/channel.rs 13.3% 13 Missing ⚠️
crates/proof-sdk/preimage/src/native_channel.rs 90.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby force-pushed the cl/fault-proof-crate branch from 7e4a4b8 to 882a409 Compare November 22, 2024 21:29
@clabby clabby marked this pull request as ready for review November 22, 2024 21:30
* feat(host): Run client program natively

* lint

* rebase

* fix

* monorepo update

* lint
@clabby clabby added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 05915c3 Nov 26, 2024
14 of 16 checks passed
@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-workspace Area: Top level workspace modifications K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants