Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGSEGV on v5 when no changes for a version (Unreleased) #86

Closed
tajobe opened this issue Dec 5, 2022 · 1 comment · Fixed by #87
Closed

SIGSEGV on v5 when no changes for a version (Unreleased) #86

tajobe opened this issue Dec 5, 2022 · 1 comment · Fixed by #87
Assignees
Labels
bug Looks like an issue v5 Release v5.x.x

Comments

@tajobe
Copy link
Contributor

tajobe commented Dec 5, 2022

Description

When attempting to create a release with no changes, the git-release action panics with a SIGSEGV.

This might seem like an unusual thing to do, but it is an artifact of CI on commit, where my intention is to always produce a latest Unreleased snapshot for any commit to master. Some commits may be non-functional and further this makes a workflow immediately following a tagged release fail every time.

Tag

v5.0.0

Workflow

https://github.com/dotRun/MCVotifierLib/blob/master/.github/workflows/publish-workflow.yml

Changelog

https://github.com/dotRun/MCVotifierLib/blob/ea11c2a594d8fa63f8b931dc996ba0ec6fc57048/CHANGELOG.md

Log

 DEBUG git-release v5.0.0                           
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x65dcae]

goroutine 1 [running]:
github.com/anton-yurchenko/go-changelog.(*Changes).ToString(0x0)
	/go/pkg/mod/github.com/anton-yurchenko/go-changelog@v1.0.4/changes.go:24 +0x2e
main.(*Configuration).GetChangelog(0xc00005c360, {0x75d400?, 0x91e9d0}, 0xc00007c240)
	/opt/src/config.go:106 +0xe5
main.main()
	/opt/src/main.go:71 +0x1e9
@anton-yurchenko anton-yurchenko added bug Looks like an issue v5 Release v5.x.x labels Dec 14, 2022
@anton-yurchenko anton-yurchenko linked a pull request Dec 14, 2022 that will close this issue
@anton-yurchenko
Copy link
Owner

Thanks @tajobe, a fix was released on v5.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Looks like an issue v5 Release v5.x.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants