Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rollup plugins and fix dependency conflict #5489

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

xcy960815
Copy link
Collaborator

@xcy960815 xcy960815 commented Aug 31, 2023

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

@hustcc
Copy link
Member

hustcc commented Aug 31, 2023

解决问题是什么?

package.json Show resolved Hide resolved
rollup.config.js Outdated Show resolved Hide resolved
rollup.config.js Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@xcy960815
Copy link
Collaborator Author

解决问题是什么?

更新 rollup 插件,顺带解决 rollup 插件依赖冲突的问题

@pearmini
Copy link
Member

pearmini commented Sep 1, 2023

看了一下,主要的变化有:

  • rollup-plugin-uglify -> @rollup/plugin-terser
  • rollup-plugin-typescript -> rollup-plugin-typescript2
  • context.widow
  • tsConfig.module : commonjs -> ESNext

@xcy960815
Copy link
Collaborator Author

看了一下,主要的变化有:

* `rollup-plugin-uglify` -> `@rollup/plugin-terser`

* `rollup-plugin-typescript` -> `rollup-plugin-typescript2`

* context.widow

* tsConfig.module : `commonjs` -> `ESNext`

是的, 还有一个就是 rollup.config.js的 采用esm 导出方式

@xcy960815
Copy link
Collaborator Author

看了一下,主要的变化有:

* `rollup-plugin-uglify` -> `@rollup/plugin-terser`

* `rollup-plugin-typescript` -> `rollup-plugin-typescript2`

* context.widow

* tsConfig.module : `commonjs` -> `ESNext`

移除 tsconfig.json的 outDir 属性

tsconfig.json Show resolved Hide resolved
rollup.config.js Show resolved Hide resolved
@pearmini pearmini merged commit e4ea223 into antvis:v5 Sep 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants