Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): add dark and update academy theme #5584

Merged
merged 2 commits into from
Sep 22, 2023
Merged

feat(theme): add dark and update academy theme #5584

merged 2 commits into from
Sep 22, 2023

Conversation

pearmini
Copy link
Member

@pearmini pearmini commented Sep 22, 2023

working on: #5571

  • 新增 dark 主题,并且调整 classicDark 主题
  • 更新 academy 主题
  • 主题可以配置交互的默认值,比如如下的 tooltip
const theme = {
  tooltip: {
    css: {}
  }
}

image

image

@coveralls
Copy link

coveralls commented Sep 22, 2023

Pull Request Test Coverage Report for Build 6270222541

  • 19 of 22 (86.36%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 88.206%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/theme/academy.ts 5 6 83.33%
src/theme/classicDark.ts 1 2 50.0%
src/theme/dark.ts 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
src/runtime/layout.ts 2 92.42%
Totals Coverage Status
Change from base Build 6259097206: -0.05%
Covered Lines: 10000
Relevant Lines: 10980

💛 - Coveralls

@pearmini pearmini changed the title feat(theme): add dark theme feat(theme): add dark and update academy theme Sep 22, 2023
@pearmini pearmini merged commit 051d719 into v5 Sep 22, 2023
2 checks passed
@pearmini pearmini deleted the feat/dark branch September 22, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants