Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quantile scale domain calculate #6126

Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix: quantile scale domain calculate #6126

merged 2 commits into from
Mar 14, 2024

Conversation

lvisei
Copy link
Member

@lvisei lvisei commented Mar 13, 2024 •
edited
Loading

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change
  • fixd quantile scale domain should‘t do repeated operations

@lvisei lvisei changed the title fix: quantile scale domain should‘t do repeated operations fix: quantile scale domain calculate Mar 13, 2024
@pearmini
Copy link
Member

需要更新一下 snapshot：删除 __tests__/integration/snapshots 下面对应的截图：

image

然后重新运行：npm run test

@pearmini pearmini mentioned this pull request Mar 14, 2024
Merged
4 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8274857927

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.794%
Totals Coverage Status
Change from base Build 8136453813: 0.0%
Covered Lines: 10153
Relevant Lines: 11199
💛 - Coveralls

@pearmini pearmini merged commit e8192d2 into v5 Mar 14, 2024
2 checks passed
@pearmini pearmini deleted the fix/quantile-domain branch March 14, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lvisei @pearmini @coveralls