Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct type definition from BaseNodeStyleProps to BaseEdgeStyl… #6676

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

GDobby
Copy link
Contributor

@GDobby GDobby commented Dec 27, 2024

修改中文文档中,自定义变类型声明错误

Copy link

Walkthrough

本次更改修正了中文文档中的类型定义错误,将 BaseNodeStyleProps 更正为 BaseEdgeStyleProps。这确保了在扩展 BaseEdge 类时使用正确的类型定义。

Changes

文件 概要
packages/site/docs/manual/custom-extension/element.zh.md 修正类型定义错误,将 BaseNodeStyleProps 更正为 BaseEdgeStyleProps


class ExtendBaseEdge extends BaseEdge {
// 重写 getKeyStyle 方法
protected getKeyStyle(attributes: Required<BaseNodeStyleProps>) {
protected getKeyStyle(attributes: Required<BaseEdgeStyleProps>) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确保在 getKeyStyle 方法中使用 BaseEdgeStyleProps 是正确的,因为这与 BaseEdge 类的扩展一致。

@Aarebecca Aarebecca merged commit 6c247fd into antvis:v5 Dec 30, 2024
1 check passed
@Aarebecca
Copy link
Contributor

Good Job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants