Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseLayer.setData,在处理大量数据图层时,速度慢 #1864

Open
wch360119203 opened this issue Sep 13, 2023 · 5 comments
Open

BaseLayer.setData,在处理大量数据图层时,速度慢 #1864

wch360119203 opened this issue Sep 13, 2023 · 5 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@wch360119203
Copy link

  • L7 Version: 2.17.7
  • Platform: Chrome 116.0.5845.111
  • Mini Showcase(like screenshots):
    微信图片_20230703153209
  • CodePen Link:

在大数据量的图层中,更新坐标的速度很慢。
我目前的解决方法是将要修改的元素设为透明,并添加新的图层来存储修改后的元素
有没有可能做一个updateData的方法,用来快速修改图层中元素的坐标

@github-actions
Copy link
Contributor

hi @wch360119203, welcome!

@github-actions github-actions bot added the good first issue Good for newcomers label Sep 13, 2023
@lzxue
Copy link
Contributor

lzxue commented Sep 13, 2023

大数据量更新卡的主要问题,每次需要重新计算数据。如果只是新增数据,可以考虑增加 addData 方法,也可以调研一下同类引擎有没有这样的机制

@github-actions
Copy link
Contributor

Hello @wch360119203. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @wch360119203,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到 master 分支,务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@lzxue
Copy link
Contributor

lzxue commented Sep 13, 2023

增量更新涉及的数据处理环节,都需要实现增量数据处理。

  • source 层数据解析
  • 图层层
    • scale 计算,固定数据样式可以不重新计算
    • mapping 数据映射
    • 顶点构建,这部分相对比较耗时,特别是线图层

你可以描述一下,你具体的使用场景,什么数据?什么图层

@wch360119203
Copy link
Author

我们正在开发一款排水管网模型在线编辑器,允许用户在网页上导入排水管网数据,并实现管道属性信息、坐标信息等各类数据的增加、删除、修改和查询等功能。
排水管网模型中,点线面图层的比例大致遵循1:1:1的比例关系。我们将原始数据转化为geojson格式(FeatuerCollection<MultiLineString|MultiPoint|MultiPolygon>),并通过使用BaseLayer.source导入L7。

这是其中一条管线的数据

{
"type": "FeatureCollection",
"name": "huli",
"features": [
{ "type": "Feature", 
"properties": { "Id": "35020301023000074", "Description": null, "Tag": null, "Note1": null, "Note2": null, "Note3": null, "Note4": null, "Note5": null, "Note6": null, "Note7": null, "Note8": null, "Note9": null, "Note10": null, "StartNodeId": "35020301063000710", "EndNodeId": "35020301013000330", "DrainageTyp": "Storm", "ResultFlow": 0.0, "ResultVeloc": 0.0, "ResultDepth": 0.0, "ResultVolum": 0.0, "ResultCapac": 0.0, "SummaryMaxF": 0.0, "SummaryMaxV": 0.0, "SummaryMaxF_1": 0.0, "SummaryMaxF_2": 0.0, "SummarySurc": "False", "SummaryHour": 0.0, "SummaryHour_1": 0.0, "SummaryHour_2": 0.0, "SummaryHour_3": 0.0, "SummaryHour_4": 0.0, "SummaryStre": "False", "SummaryMaxS": 0.0, "SummaryMaxD": 0.0, "SummaryUpst": 0.0, "SummaryDown": 0.0, "ShapeDispla": "CIRCULAR", "Height": 0.3, "Width": 0.3, "Length": 10.50466506, "Roughness": 0.013, "InletElevat": 1.15, "OutletEleva": 0.85, "Gradient": 0.02855874, "InitialFlow": 0.0, "MaximumFlow": 0.0, "EntryLossCo": 0.0, "ExitLossCoe": 0.0, "AvgLossCoef": 0.0, "SeepageLoss": 0.0, "FlapGate": "False", "CulvertCode": null, "ResultFulln": 0.0, "IsDesignLin": "False", "RefDesignTy": "None", "IsConnected": "False" },
 "geometry": { "type": "MultiLineString", "coordinates": [ [ [ 118.079649948, 24.478211011 ], [ 118.079546611, 24.47820397 ] ] ] } 
},
]}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Development

No branches or pull requests

3 participants