From ef5e3eb865fff7c82928aefa6ed3e958ecc6f6a4 Mon Sep 17 00:00:00 2001 From: yunji Date: Wed, 13 Nov 2024 22:43:35 +0800 Subject: [PATCH 1/2] fix: domain default undefined --- packages/layers/src/plugins/FeatureScalePlugin.ts | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/layers/src/plugins/FeatureScalePlugin.ts b/packages/layers/src/plugins/FeatureScalePlugin.ts index 5eb80eb9a0..07e17a2763 100644 --- a/packages/layers/src/plugins/FeatureScalePlugin.ts +++ b/packages/layers/src/plugins/FeatureScalePlugin.ts @@ -251,8 +251,12 @@ export default class FeatureScalePlugin implements ILayerPlugin { data?: IParseDataItem[], ) { const cfg: IScale = { + ...scaleOption, type, }; + + if (cfg?.domain) return cfg; + // quantile domain 需要根据ID 进行去重 let values = []; if (type === ScaleTypes.QUANTILE) { @@ -266,9 +270,7 @@ export default class FeatureScalePlugin implements ILayerPlugin { values = data?.map((item) => item[field]) || []; } - if (scaleOption?.domain) { - cfg.domain = scaleOption?.domain; - } else if (type === ScaleTypes.CAT || type === ScaleTypes.IDENTITY) { + if (type === ScaleTypes.CAT || type === ScaleTypes.IDENTITY) { cfg.domain = uniq(values); } else if (type === ScaleTypes.QUANTILE) { cfg.domain = values; @@ -281,7 +283,8 @@ export default class FeatureScalePlugin implements ILayerPlugin { // linear/Power/log cfg.domain = extent(values); } - return { ...cfg, ...scaleOption }; + + return cfg; } // 创建Scale 实例 From 29d63bf8d0021bab7899007bca831483305ee20c Mon Sep 17 00:00:00 2001 From: yunji Date: Wed, 13 Nov 2024 22:50:25 +0800 Subject: [PATCH 2/2] chore: add changeset --- .changeset/heavy-glasses-compete.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/heavy-glasses-compete.md diff --git a/.changeset/heavy-glasses-compete.md b/.changeset/heavy-glasses-compete.md new file mode 100644 index 0000000000..f3d5918e4c --- /dev/null +++ b/.changeset/heavy-glasses-compete.md @@ -0,0 +1,5 @@ +--- +'@antv/l7-layers': patch +--- + +fix: scale domain when default undefined