fix(label): support date label (#5077)

antvis · May 23, 2023 · 826e000 · 826e000
1 parent 1ee4b1f
commit 826e000
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 2 deletions.
diff --git a/__tests__/integration/snapshots/static/aaplIntervalDateEncodeX.png b/__tests__/integration/snapshots/static/aaplIntervalDateEncodeX.png
diff --git a/__tests__/integration/spec-static.spec.ts b/__tests__/integration/spec-static.spec.ts
@@ -12,8 +12,10 @@ describe('Charts', () => {
     it(`[Canvas]: ${name}`, async () => {
       try {
         // @ts-ignore
-        const { maxError = 0 } = generateOptions;
+        const { maxError = 0, before, after } = generateOptions;
+        before?.();
         gCanvas = await renderSpec(generateOptions);
+        after?.();
         const dir = `${__dirname}/snapshots/static`;
         await expect(gCanvas).toMatchCanvasSnapshot(dir, name, { maxError });
       } finally {

diff --git a/__tests__/plots/static/aapl-interval-date-encode-x.ts b/__tests__/plots/static/aapl-interval-date-encode-x.ts
@@ -0,0 +1,29 @@
+import { G2Spec } from '../../../src';
+
+export function aaplIntervalDateEncodeX(): G2Spec {
+  return {
+    type: 'interval',
+    padding: 'auto',
+    height: 720,
+    data: {
+      type: 'fetch',
+      value: 'data/aapl.csv',
+      transform: [{ type: 'slice', start: 0, end: 10 }],
+    },
+    encode: {
+      x: 'date',
+      y: 'close',
+    },
+  };
+}
+
+let toString;
+
+aaplIntervalDateEncodeX.before = () => {
+  toString = Date.prototype.toString;
+  Date.prototype.toString = Date.prototype.toUTCString;
+};
+
+aaplIntervalDateEncodeX.after = () => {
+  Date.prototype.toString = toString;
+};
diff --git a/__tests__/plots/static/index.ts b/__tests__/plots/static/index.ts
@@ -226,3 +226,4 @@ export { populationIntervalDivergingAutoPaddingUndefinedTitle } from './populati
 export { tranLineMultiAxesAutoPaddingTickMethod } from './train-line-multi-axes-auto-padding-tick-method';
 export { vaccinesCellScaleRelationAutoPaddingTickFilter } from './vaccines-cell-scale-relation-auto-padding-tick-filter';
 export { marketIntervalMarimekkoAutoPaddingFlex } from './market-interval-marimekko-auto-padding-flex';
+export { aaplIntervalDateEncodeX } from './aapl-interval-date-encode-x';
diff --git a/src/component/axis.ts b/src/component/axis.ts
@@ -148,7 +148,12 @@ function getData(
 
   const ticks = ticksOf(scale, domain, tickMethod);
   const filteredTicks = tickFilter ? ticks.filter(tickFilter) : ticks;
-  const toString = (d) => (typeof d === 'object' && !!d ? d : String(d));
+  const toString = (d) =>
+    d instanceof Date
+      ? String(d)
+      : typeof d === 'object' && !!d
+      ? d
+      : String(d);
   const labelFormatter =
     defaultTickFormatter || scale.getFormatter?.() || toString;
   const applyInset = createInset(position, coordinate);