Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): lock version of canvas to 2.11.0 #4857

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix(ci): lock version of canvas to 2.11.0 #4857

merged 1 commit into from
Apr 3, 2023
+1 −3

Conversation

pearmini
Copy link
Member

@pearmini pearmini commented Apr 3, 2023

修复 node canvas v2.11.1 升级带来的问题。

  • 问题原因：node canvas 修复了之前 letter-spacing 不正确的问题，导致截图有文本的地方全部不匹配。
  • 解决办法：暂时锁定版本到 v2.11.0，因为之后要替换测试为 playwright，到时候再统一升级。

@pearmini pearmini merged commit c47cbc2 into v5 Apr 3, 2023
@pearmini pearmini deleted the fix/ci branch April 3, 2023 03:41
hustcc pushed a commit that referenced this pull request May 16, 2023
@pearmini @hustcc
fix(ci): lock version of canvas to 2.11.0 (#4857)
64edffc
hustcc pushed a commit that referenced this pull request May 16, 2023
@pearmini @hustcc
fix(ci): lock version of canvas to 2.11.0 (#4857)
37322e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aarebecca Aarebecca Aarebecca approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pearmini @Aarebecca