fix: change data wont update #5002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aarebecca
force-pushed
the
fix/fix-legend-update
branch
from
74686e6
to
41fd8c9
Compare
pearmini
approved these changes
May 11, 2023
Aarebecca
force-pushed
the
fix/fix-legend-update
branch
from
41fd8c9
to
1d097fd
Compare
Aarebecca
force-pushed
the
fix/fix-legend-update
branch
from
1d097fd
to
63a86f1
Compare
hustcc
changed the title
pearmini
approved these changes
May 12, 2023
hustcc
pushed a commit
that referenced
this pull request
May 16, 2023
* fix: fix issue that change data wont update * test: update test snapshot
hustcc
pushed a commit
that referenced
this pull request
May 16, 2023
* fix: fix issue that change data wont update * test: update test snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
主要原因是图例组件使用 Layout 组件包了一层
导致 plot runtime 更新组件属性时，拿到的属性是从 Layout 组件上拿的，并没有取到组件的数据，导致没有更新上