Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(legend): set actual item size #5326

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix(legend): set actual item size #5326

merged 1 commit into from
Jul 18, 2023

Conversation

pearmini
Copy link
Member

@pearmini pearmini commented Jul 18, 2023 •
edited
Loading

  • 存在问题：之前 item maker 是通过 scale 来达到 itemMarkerSize 的大小，这样会导致 stoke 也被 scale（feat(size): support ordinal size channel #5320 第二个问题）
  • 解决办法：传入真实的 markerSize。

@pearmini pearmini force-pushed the fix/legend branch 2 times, most recently from 70c6e95 to b6bec55 Compare July 18, 2023 08:21
@pearmini pearmini merged commit 683d529 into v5 Jul 18, 2023
@pearmini pearmini deleted the fix/legend branch July 18, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pearmini @hustcc