Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scale): group scale by name and index #5815

Merged
merged 1 commit into from
Nov 20, 2023
Merged

fix(scale): group scale by name and index #5815

merged 1 commit into from
Nov 20, 2023

Conversation

pearmini
Copy link
Member

fix: #5654
fix: #5535

修改这个 PR #5291 带来的问题:不能根据 scaleKey 去存储 scale,还是根据通道名字和索引去存储。

chart.options({
  scale: { x: { key: 'main' }}
})

内部生成的 scale 如下:

const scale = {
  main: {}
}

而不是

const scale = {
  x: {}
}

所以导致了以上的两个问题。

Copy link
Collaborator

@ai-qing-hai ai-qing-hai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear scalekey , by group scale

@pearmini pearmini merged commit 2808b74 into v5 Nov 20, 2023
3 checks passed
@pearmini pearmini deleted the fix/scale-key branch November 20, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants