Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interaction): add elementpointmove interaction #6110

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Conversation

ai-qing-hai
Copy link
Collaborator

@ai-qing-hai ai-qing-hai commented Mar 5, 2024

add elementPointMove

image

  • line add
    • 折线图可用
    • 雷达图可用
    • 面积图可用
  • interval add
    • 柱状图可用
    • 条形图可用
    • 饼图可用

@coveralls
Copy link

coveralls commented Mar 5, 2024

Pull Request Test Coverage Report for Build 8278515395

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 104 of 299 (34.78%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.4%) to 86.44%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/interaction/utils.ts 6 19 31.58%
src/interaction/elementPointMove.ts 96 278 34.53%
Totals Coverage Status
Change from base Build 8136453813: -1.4%
Covered Lines: 10255
Relevant Lines: 11496

💛 - Coveralls

@ai-qing-hai ai-qing-hai changed the title [WIP](interaction): add elementpointmove interaction feat(interaction): add elementpointmove interaction Mar 7, 2024
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很优秀,几个 API 设计可能还需要考虑一下。

@pearmini pearmini merged commit e36ce30 into v5 Mar 14, 2024
2 checks passed
@pearmini pearmini deleted the feat-pointmove branch March 14, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants