Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scale options rangeMin and rangeMax #6125

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix: scale options rangeMin and rangeMax #6125

merged 1 commit into from
Mar 14, 2024

Conversation

lvisei
Copy link
Member

@lvisei lvisei commented Mar 13, 2024

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

fixed scale options rangeMax and rangeMax

@hustcc
Copy link
Member

hustcc commented Mar 13, 2024

加个单侧！

@pearmini pearmini changed the title fix: scale options rangeMax and rangeMax fix: scale options rangeMin and rangeMax Mar 14, 2024
@pearmini
Copy link
Member

同理 #6126 (comment)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8276289941

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.794%
Totals Coverage Status
Change from base Build 8276164428: 0.0%
Covered Lines: 10153
Relevant Lines: 11199
💛 - Coveralls

@pearmini pearmini merged commit f11e9f9 into v5 Mar 14, 2024
2 checks passed
@pearmini pearmini deleted the fix/range-min branch March 14, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lvisei @hustcc @pearmini @coveralls