Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dodgeX): do not update series channel if groupBy is invalid #6344

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

pearmini
Copy link
Member

@pearmini pearmini commented Jul 3, 2024

close: #6328

  • 出现问题原因:数据本来没有排序,也没有指定 dodgeX 的排序规则,但是更新了 series 的顺序,反而让顺序和数据顺序不一致。
  • 对于没有 orderBy 的 dodgeX,不去更新 series。

@pearmini pearmini merged commit 87c39da into v5 Jul 3, 2024
2 checks passed
@pearmini pearmini deleted the fix-series-error-order branch July 3, 2024 07:02
@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9773232813

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 4 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 86.332%

Files with Coverage Reduction New Missed Lines %
src/transform/dodgeX.ts 8 60.61%
Totals Coverage Status
Change from base Build 9710690383: -0.06%
Covered Lines: 10409
Relevant Lines: 11677

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

图例显示顺序与分组柱状图绘制不同
3 participants