Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): add no selected elements display for itme-filter #6374

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

Runtus
Copy link
Contributor

@Runtus Runtus commented Jul 22, 2024

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change
  • 为item-filter增加了全部都不选中时的可视化图展示。
    image
    image

fixed: #5997

@pearmini
Copy link
Member

pearmini commented Jul 23, 2024

@Runtus 可以看看 CI 的问题😝

@Runtus
Copy link
Contributor Author

Runtus commented Jul 23, 2024

好的,我晚上看看,不好意思,这几天突然又忙起来了哈哈哈

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10070466312

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 11 of 14 (78.57%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.05%) to 86.668%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/transform/filter.ts 11 14 78.57%
Files with Coverage Reduction New Missed Lines %
src/composition/facetRect.ts 1 99.09%
src/composition/utils.ts 1 90.0%
src/runtime/plot.ts 1 97.93%
src/interaction/sliderFilter.ts 2 94.41%
Totals Coverage Status
Change from base Build 9990424131: 0.05%
Covered Lines: 10539
Relevant Lines: 11785

💛 - Coveralls

Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Runtus 很优秀 🎉🎉🎉

src/transform/filter.ts Show resolved Hide resolved
@pearmini pearmini merged commit 27dfc5e into antvis:v5 Jul 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

怎么设置图例全部不选中
3 participants