Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 主题中增加图例样式的配置,便于用户了解怎么修改 #3376

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Apr 15, 2021

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

legend 的状态样式写死在 component 中,其实是可以修改的;参考下面两个文件:

  1. https://github.com/antvis/component/blob/7d74c4753ce4cc5bcb54f8f278f9ea62d6a0c6bf/src/util/theme.ts
  2. https://github.com/antvis/component/blob/912fb582894be39307b508edbd0468ea7fca16d1/src/legend/category.ts#L109

closed: #3375

@visiky visiky requested review from hustcc and lxfu1 April 15, 2021 05:57
@coveralls
Copy link

coveralls commented Apr 15, 2021

Pull Request Test Coverage Report for Build 750911505

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.509%

Totals Coverage Status
Change from base Build 743742278: 0.0%
Covered Lines: 10916
Relevant Lines: 11321

💛 - Coveralls

@hustcc hustcc merged commit 5d3fac4 into master Apr 21, 2021
@hustcc hustcc deleted the legend-style branch April 21, 2021 05:19
@3012852661
Copy link

你好,我想问一下,图例的每一项内容太长超过之后会隐藏,那么鼠标hover上去的tooltip样式可以通过什么方式修改呢?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set active color and inactive color of legend in dark theme
4 participants