Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: AxisCfg API title.title => title.text #2277

Merged
merged 1 commit into from
Jan 27, 2021
Merged

docs: AxisCfg API title.title => title.text #2277

merged 1 commit into from
Jan 27, 2021

Conversation

mayneyao
Copy link
Contributor

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After
❌ ✅

@mayneyao
Copy link
Contributor Author

image
image
文档中设置 title 不生效，换成 text 才行。

@coveralls
Copy link

coveralls commented Jan 27, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 514841110

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.712%
Totals Coverage Status
Change from base Build 514362505: 0.0%
Covered Lines: 4756
Relevant Lines: 4803
💛 - Coveralls

@visiky visiky self-requested a review January 27, 2021 10:30
@visiky
Copy link
Member

visiky commented Jan 27, 2021

axis.en.md 也顺便改下？

@visiky visiky merged commit 067f6b0 into antvis:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayneyao @coveralls @visiky