Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(animation): 增加动画文档和 demo & 多图层图表支持分view动画 #2291

Merged
merged 12 commits into from
Feb 1, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jan 31, 2021

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2021

😭 Deploy PR Preview 19f5a26 failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Jan 31, 2021

Pull Request Test Coverage Report for Build 526424654

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 96.685%

Files with Coverage Reduction New Missed Lines %
src/plots/multi-view/adaptor.ts 1 96.72%
Totals Coverage Status
Change from base Build 519973899: -0.03%
Covered Lines: 4760
Relevant Lines: 4808

💛 - Coveralls

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

examples/dynamic-plots/animation/demo/animation-line.jsx Outdated Show resolved Hide resolved
examples/dynamic-plots/animation/demo/animation-column.jsx Outdated Show resolved Hide resolved
examples/dynamic-plots/animation/demo/animation-line.jsx Outdated Show resolved Hide resolved
examples/dynamic-plots/animation/demo/animation-column.jsx Outdated Show resolved Hide resolved
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

examples/dynamic-plots/animation/demo/animation-pie.jsx Outdated Show resolved Hide resolved
examples/dynamic-plots/animation/demo/animation-pie.jsx Outdated Show resolved Hide resolved
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

examples/dynamic-plots/animation/demo/animation-pie.jsx Outdated Show resolved Hide resolved
examples/dynamic-plots/animation/demo/animation-pie.jsx Outdated Show resolved Hide resolved
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

examples/dynamic-plots/animation/demo/animation-pie.jsx Outdated Show resolved Hide resolved
examples/dynamic-plots/animation/demo/animation-pie.jsx Outdated Show resolved Hide resolved
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@visiky visiky changed the title feat(animation): 增加动画文档和 demo & 多图层图表支持分view动画' feat(animation): 增加动画文档和 demo & 多图层图表支持分view动画 Jan 31, 2021
// @ts-ignore
expect(plot.chart.views[0].options.animate).toBe(true);
// @ts-ignore
expect(plot.chart.views[0].geometries[0].animateOption.appear.animation).toBe('fade-in');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plot.destroy()

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@visiky visiky merged commit 9e62cb9 into master Feb 1, 2021
@visiky visiky deleted the feat-animation branch February 1, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants