Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No translation of text in brackets #2297

Closed
Candice-Louw opened this issue Nov 25, 2022 · 2 comments · Fixed by #2708
Closed

No translation of text in brackets #2297

Candice-Louw opened this issue Nov 25, 2022 · 2 comments · Fixed by #2708
Labels
bug Something isn't working.

Comments

@Candice-Louw
Copy link

Describe the bug

Translation of text in brackets does not seem to occur, irrespective of the set locale. By default, it is always displaying in English. The rest of the text is translating fine.

This is applicable to the (last year) sub-string in the Contributed to (last year) string as displayed on the github-stats-card.

Expected behaviour

Text between brackets should be translated based on the set locale.

Screenshots / Live demo link

Example locale=de
image

Example locale=fr
image

Example locale=nl
image

Additional context

Current card with locale=de
Candice's GitHub stats

@Candice-Louw Candice-Louw added the bug Something isn't working. label Nov 25, 2022
@rickstaa
Copy link
Collaborator

@Candice-Louw Thanks for your bug report. That text was recently added, so I didn't yet make it translatable. We are currently updating the translation system, which will ease the process, so I will probably add it after that is done (see #2053).

@rickstaa
Copy link
Collaborator

rickstaa commented May 8, 2023

Will be fixed in #2708.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants