Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Сonfusing behavior of showing 0 commits when upstream API fails. #3225

Closed
qwerty541 opened this issue Sep 12, 2023 · 2 comments · Fixed by #3238
Closed

Сonfusing behavior of showing 0 commits when upstream API fails. #3225

qwerty541 opened this issue Sep 12, 2023 · 2 comments · Fixed by #3238
Labels
enhancement New feature or request. stats-card Feature, Enhancement, Fixes related to stats the stats card.

Comments

@qwerty541
Copy link
Collaborator

qwerty541 commented Sep 12, 2023

Related to #3186 (comment)

Problem

I think that current behavior of stats card which shows 0 commits when upstream API fails and &include_all_commits=true query parameter specified is wrong bacause such behavior is not obvious for users and confuse them. Recently i also had to answer some issues/discussions with questions from users about why their card showing 0 commits. I think it would be pretty stupid to show users zero statistics for every error instead of error message, but for some reason the total number of commits is done this way, I personally don’t see any particular reason to leave this behavior.

Suggested solution

I think that it will be better to render error card with message aksking user to try later in this case.

@rickstaa Let me know if you are up to approve such changes, then i will try to find time for creating a pull request.

@qwerty541 qwerty541 added enhancement New feature or request. stats-card Feature, Enhancement, Fixes related to stats the stats card. labels Sep 12, 2023
@rickstaa
Copy link
Collaborator

@ qwerty541 such an improvement would be remarkable since the current behavoir is strange. We can improve the caching behavoir to make the card try earlier when this endpoint fails. See all comments at #2448 👍🏻. I don't have enough OS budget to implement such a think; feel free to take this on if you have the time.

@qwerty541
Copy link
Collaborator Author

@rickstaa Recently i have opened #3238 which should resolve this issue, check it please when you have free time.

Pull request #2448 with improving of error caching behavior looks good to me, i will try to find time to merge it with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. stats-card Feature, Enhancement, Fixes related to stats the stats card.
Projects
None yet
2 participants