Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trophies Card #3613

Open
RokeJulianLockhart opened this issue Jan 25, 2024 · 1 comment
Open

Trophies Card #3613

RokeJulianLockhart opened this issue Jan 25, 2024 · 1 comment
Labels
enhancement New feature or request. feature new-card New card proposal.

Comments

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Jan 25, 2024

Is your feature request related to a problem? Please describe.

I currently use https://github-profile-trophy.vercel.app/?username=RokeJulianLockhart&theme=default&no-frame=false&no-bg=false&margin-w=4, but it doesn't support a transparent theme.

Describe the solution you'd like

Create a Trophy card.

Describe alternatives you've considered

https://github-profile-trophy.vercel.app/?username=RokeJulianLockhart&theme=default&no-frame=false&no-bg=false&margin-w=4

Additional context

https://github.com/RokeJulianLockhart#statistics

@RokeJulianLockhart RokeJulianLockhart added the enhancement New feature or request. label Jan 25, 2024
@qwerty541
Copy link
Collaborator

Hey, @RokeJulianLockhart! Thanks for your feature request.

To be honest I don't think that the need of transparent theme is enough reason to duplicate trophy card inside this repository. The much easier solution will be submitting feature request to the https://github.com/ryo-ma/github-profile-trophy. They already support customizing card with themes, so adding a new one hardly will be a concern.

Recently we have discussed with other maintainers very similar issue. It was the addition of streak stats card which was already implemented in another project. This feature was rejected with the following conclusion #3338 (comment) .

In my opinion addition of trophy card only make sense in case if someone will create an unique design.

Of course let's wait for other maintainers input about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. feature new-card New card proposal.
Projects
None yet
Development

No branches or pull requests

2 participants