Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: the date conversion has still issue even after the update of number of days #13

Closed
novaprime-code opened this issue May 10, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@novaprime-code
Copy link

What happened?

I cannot convert 2081-02-32 to AD date

How to reproduce the bug

Try converting 2081-02-32 to AD

Package Version

1.6

PHP Version

8.2

Laravel Version

10.0

Which operating systems does with happen with?

Linux

Notes

Thank you in advance

@novaprime-code novaprime-code added the bug Something isn't working label May 10, 2024
@anuzpandey
Copy link
Owner

anuzpandey commented May 11, 2024

Hello @novaprime-code.

The issue has been identified and to solve this problem I might have to re-write the whole toEnglishDate() function. Since the package use Carbon extension, the problem is, it cannot set 32 to any of months. I will get this fixed by the end of the week.

The feature you requested for daysInMonth and daysInYear has been completed. It will be available from the release of 1.7.0.

@anuzpandey anuzpandey self-assigned this May 11, 2024
@novaprime-code
Copy link
Author

Thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants