Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: valid syntax when anyOf is present on querystring #1341

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

arthurfiorette
Copy link
Contributor

@arthurfiorette arthurfiorette commented Apr 30, 2024

Status

READY

Description

Fix #884.

Tests were also added. I'm not familiar enough with the orval codebase (for now haha), but I think this fix is enough. Also tested on our production codebase and can confirm the problem was fixed.

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

@melloware melloware added the bug Something isn't working label Apr 30, 2024
@melloware melloware requested a review from anymaniax April 30, 2024 18:16
@melloware melloware added this to the 6.28.0 milestone Apr 30, 2024
@melloware melloware requested a review from soartec-lab April 30, 2024 18:16
@arthurfiorette
Copy link
Contributor Author

What should I do to create add a changelog entry?

@arthurfiorette arthurfiorette changed the title fix: anyOf on querystring fix: valid syntax when anyOf is present on querystring Apr 30, 2024
@melloware
Copy link
Collaborator

That I don't know I have never done one so I think your PR is ok for now.

@melloware melloware merged commit 41f6612 into orval-labs:master Apr 30, 2024
2 checks passed
@melloware melloware modified the milestones: 6.28.0, 6.29.0 May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enums are parsed to invalid Typescript
3 participants