fix: relative hono handler imports when using tag mode #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melloware
approved these changes
Aug 11, 2024
|
LGTM thanks! |
|
@anymaniax you did all the Hono development so figured you want to review |
anymaniax
approved these changes
Aug 11, 2024
|
Thanks! |
|
@fredericgrati don’t hesitate to ping me on the discord if you want to discuss about it or need something for the Hono client. I still need to write a bit of doc for it too 😅 |
|
And thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Fix #1573
Description
The logic to account for the tag in the relative path already existed during the generation of the handlers.
I simply reused it when creating the imports for the handlers in the hono routes.