New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old $eq definition doesn't use deepEqual #16

Open

icio opened this issue Sep 29, 2020 · 0 comments

icio commented Sep 29, 2020 •

edited

Loading

Happened to spot this when having a play around:

joqular/index.js

Lines 638 to 641 in c0c90b1

    
           $eq(a,b,depth,unordered) { 
        
           	return a==b; 
        
           	//deepEqual(test,value,depth,unordered); 
        
           },

It overrides the more useful looking definition at:

joqular/index.js

Lines 606 to 611 in c0c90b1

    
           $eq(a,b) { 
        
           	if(a && b && typeof(a)==="object" && typeof(b)==="object") { 
        
           		return deepEqual(a,b); 
        
           	} 
        
           	return a == b;  
        
           },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment