Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go generated import statements sometimes contain an extra / #118

Open
andrewemeryanz opened this issue Jun 1, 2020 · 2 comments
Open

Go generated import statements sometimes contain an extra / #118

andrewemeryanz opened this issue Jun 1, 2020 · 2 comments
Assignees
Labels
P2 Low priority

Comments

@andrewemeryanz
Copy link
Contributor

Description

Sometimes generated code seems to contain an extra / which needs to be removed manually. I have only noticed this with sysl specs that import a swagger file. Ask @anzboi for the repo where I first noticed this problem

Steps to Reproduce

As best as I can tell, this is how I produced the error. It may not occur for every swagger import

  1. Use the sysl-go template to create a repo
  2. Update the simple.sysl file to import your new swagger file
  3. run make

Generated code contains imports like

import path/to/dependency//package

Expected behavior:

Imports should only contain a single / per path element.

Actual behavior:

Sometimes imports contain two

Your Environments

$ sysl info
Build:
  Version      : 0.76.0
  Git Commit   : c89f026
  Date         : 2020-05-04T06:30:28Z
  Go Version   : go1.13.10 linux/amd64
  OS           : darwin/amd64
Runtime:
  GOOS/GOARCH  : darwin/amd64
  Go Version   : go1.13.10

$ sysl env
SYSL_MODULES=""
SYSL_PLANTUML=""

Relocated from anz-bank/sysl#833
Raised by @anzboi

@andrewemeryanz
Copy link
Contributor Author

@anzboi Are you able to reproduce this issue currently? A similar looking issue was fixed a few months ago but we can revisit if it's still presenting.

@andrewemeryanz andrewemeryanz added P2 Low priority and removed P0 Highest priority: important and urgent labels Jun 18, 2020
@andrewemeryanz
Copy link
Contributor Author

Deprioritising until further feedback received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Low priority
Projects
None yet
Development

No branches or pull requests

1 participant