Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana-type-overrides is causing dependency bloat #1775

Closed
kevinheavey opened this issue Jun 18, 2024 · 2 comments · Fixed by #1792
Closed

solana-type-overrides is causing dependency bloat #1775

kevinheavey opened this issue Jun 18, 2024 · 2 comments · Fixed by #1792
Assignees

Comments

@kevinheavey
Copy link

Problem

solana-type-overrides was added to multiple crates in #1634

The following crates do not use futures but because they depend on solana-type-overrides they now depend on futures:

  • solana-program-runtime
  • solana-bpf-loader-program
  • solana-loader-v4-program
  • solana-stake-program
  • solana-system-program
  • solana-svm

Proposed Solution

Move solana_type_overrides::executor to a new crate

@LucasSte
Copy link

Move solana_type_overrides::executor to a new crate

Instead of creating a new crate, we can mark futures as an optional decency and put the executor module behind a cfg feature. This way, crates that need the module import type_overrides with the feature enabled and the dependency is only built when necessary.

@kevinheavey
Copy link
Author

Crates are friendlier to parallel builds and have fewer footguns like failing to check a feature in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants