forked from solana-labs/solana
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circular dependency check in CI is wrong about dev-dependencies #2428
Comments
I assumed circular dev deps were fine because |
More investigation reveals that Example repo here: https://github.com/kevinheavey/circular-dev-dep |
Was this addressed with #2578? |
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
It's fine to have apparent circular dependencies if they're just dev-dependencies [UPDATE: they must also be path dependencies], but order-crates-for-publishing.py will still fail in this case.
Unfortunatelycargo metadata
doesn't yet have a way to ignore dev-dependencies: rust-lang/cargo#10718Proposed Solution
I'll open this one up to the floor, but I see the Python script has adependency['kind'] == 'dev'
check in there - maybe we can just use this check to filter out all dev deps?Filter out path dev-dependencies in order-crates-for-publishing.py
The text was updated successfully, but these errors were encountered: