SVM: Group transaction processing configs #1475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The SVM's transaction processing functions -
load_and_execute_sanitized_transactions
and
execute_loaded_transaction
- are quickly becoming overloaded with inputs.Since many of these inputs are optional configurations to customize transaction
processing behavior, it makes sense to group these together, in a type that implements
Default
, and require only a reference to said type to process transactions.This would make integrating the transaction processor's API with a set of configs much
more idiomatic.
Summary of Changes
Group all optional configurations for processing transactions into a new configuration
object:
TransactionProcessingConfig
and require a reference to this object in theSVM API.
Adiós
#[allow(clippy::too_many_arguments)]
!