scheduler optimization - worker precompile verification #1531
Conversation
apfitzge
force-pushed
the
pcv_optimization
branch
from
7804f40 to
6cff6e7
Compare
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
(cherry picked from commit 0d34a1a) # Conflicts: # core/src/banking_stage/consumer.rs
| Ok(_) => tx.verify_precompiles(&bank.feature_set), | ||
| Err(err) => Err(err), | ||
| }) | ||
| .collect(); |
There was a problem hiding this comment.
Does this need to add another allocation?
There was a problem hiding this comment.
Discussed offline that this is to ensure that downstream timing isn't affected by this extra verification
There was a problem hiding this comment.
ok, probably deserves a comment at least
| pub fn build_sanitized_transaction( | ||
| &self, | ||
| feature_set: &Arc<feature_set::FeatureSet>, | ||
| _feature_set: &Arc<feature_set::FeatureSet>, |
There was a problem hiding this comment.
why not remove? reduce backport diff?
…ort of anza-xyz#1531) (anza-xyz#1535) * scheduler optimization - worker precompile verification (anza-xyz#1531) (cherry picked from commit 0d34a1a) # Conflicts: # core/src/banking_stage/consumer.rs * resolve conflicts --------- Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
Problem
scheduler is single threaded. doing precompile verification during the intial sanitization is thus also single-threaded.
Summary of Changes
move precompile verification to worker threads to improve efficiency
Fixes #