Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pings received contact-infos on gossip socket address #1615

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

behzadnouri
Copy link

Problem

bandwidth wasted on useless contact-infos.

Summary of Changes

ping received contact-infos on gossip socket address

@behzadnouri behzadnouri force-pushed the ping-contact-info branch 4 times, most recently from cd71012 to fc39425 Compare June 5, 2024 22:13
@behzadnouri behzadnouri requested a review from gregcusack June 5, 2024 22:13
Copy link

@gregcusack gregcusack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@behzadnouri behzadnouri merged commit 329a186 into anza-xyz:master Jun 6, 2024
42 checks passed
@behzadnouri behzadnouri deleted the ping-contact-info branch June 6, 2024 18:59
Copy link

mergify bot commented Jun 6, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Jun 6, 2024
(cherry picked from commit 329a186)

# Conflicts:
#	gossip/src/cluster_info.rs
#	gossip/src/legacy_contact_info.rs
behzadnouri added a commit that referenced this pull request Jun 7, 2024
…t of #1615) (#1635)

* pings received contact-infos on gossip socket address (#1615)

(cherry picked from commit 329a186)

# Conflicts:
#	gossip/src/cluster_info.rs
#	gossip/src/legacy_contact_info.rs

* resolves merge conflicts

---------

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
anwayde pushed a commit to firedancer-io/agave that referenced this pull request Jul 23, 2024
…t of anza-xyz#1615) (anza-xyz#1635)

* pings received contact-infos on gossip socket address (anza-xyz#1615)

(cherry picked from commit 329a186)

# Conflicts:
#	gossip/src/cluster_info.rs
#	gossip/src/legacy_contact_info.rs

* resolves merge conflicts

---------

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants