ledger-tool: Deprecate bank-hash command #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledger-tool in general has a lot of commands that can be tough to navigate. This command in general is pretty minimal, and could seemingly be an optional flag to verify. For now, leave the command present but print an error message. This command will completely removed in the future
|
I'm open to general thoughts on this one. My thinking is that the functionality offered by the command is minimal, and doesn't warrant a command. I have similar thoughts for |
samkim-crypto
pushed a commit
to samkim-crypto/agave
that referenced
this pull request
Jul 31, 2024
ledger-tool has a somewhat cluttered interface. The bank-hash command offers little extra functionality compared to what the verify command does, and could instead be an optional flag for the verify command. This change leaves the bank-hash command present, but prints an error message and tells the user to instead use verify --print-bank-hash. The command will be removed altogether in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ledger-tool has a somewhat cluttered interface. The bank-hash command
offers little extra functionality compared to what the verify command
does, and could instead be an optional flag for the verify command.
Summary of Changes
This change leaves the bank-hash command present, but prints an error
message and tells the user to instead use verify --print-bank-hash. The
command will be removed altogether in the future.