Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multinode demo, bank-hash is deprecated in ledger tool #1740

Closed
wants to merge 2 commits into from

Conversation

wen-coding
Copy link

ledger-tool has deprecated bank-hash in #1710, use the new command and parse the output.

@wen-coding wen-coding requested a review from steviez June 14, 2024 00:46
@wen-coding wen-coding self-assigned this Jun 14, 2024
@steviez
Copy link

steviez commented Jun 14, 2024

Ugh dang it, thanks for catching this; I searched around a bit but must have missed this. I'm somewhat inclined to change the ledger-tool command to spit out only the hash so that we don't have to do any parsing here; thoughts ?

@wen-coding
Copy link
Author

wen-coding commented Jun 14, 2024

Ugh dang it, thanks for catching this; I searched around a bit but must have missed this. I'm somewhat inclined to change the ledger-tool command to spit out only the hash for the hash so that we don't have to do any parsing here; thoughts ?

That would be the best. I don't suppose many people need the "bank hash is:" part since they specifically asked for it.

@steviez
Copy link

steviez commented Jun 14, 2024

Ugh dang it, thanks for catching this; I searched around a bit but must have missed this. I'm somewhat inclined to change the ledger-tool command to spit out only the hash for the hash so that we don't have to do any parsing here; thoughts ?

That would be the best. I don't suppose many people need the "bank hash is:" part since they specifically asked for it.

Sweet, I made #1745, which removes the extra text + updates the script. Will add you as a reviewer once CI completes

@wen-coding wen-coding closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants