Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger-tool: Make verify --print-bank-hash support json #1745

Merged
merged 8 commits into from
Jun 20, 2024
Merged

ledger-tool: Make verify --print-bank-hash support json #1745

merged 8 commits into from
Jun 20, 2024

Commits on Jun 14, 2024

  1. ledger-tool: Print only the bank-hash for --print-bank-hash 

    The bank-hash command was previously used in some of the scripts to spin
up a cluster. The change that deprecated the bank-hash command broke the
script. So, this change:
- Makes --print-bank-hash ONLY print the hash, no additional text to
  avoid any overhead around parsing
- Update the remote-node.sh script to use verify --print-bank-hash
    @steviez
    steviez committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    8d2d1e1 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Make --print-bank-hash support json via --output json

    @steviez
    steviez committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2af3939 View commit details
    Browse the repository at this point in the history

  2. Make cluster setup nodes install jq

    @steviez
    steviez committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    12faa6a View commit details
    Browse the repository at this point in the history

  3. Update script to use jq to parse bank-hash from ledger-tool command

    @steviez
    steviez committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    f0227cc View commit details
    Browse the repository at this point in the history

  4. Make install-jq.sh executable

    @steviez
    steviez committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    a99cd89 View commit details
    Browse the repository at this point in the history

  5. Make hash a string so it serializes as a base58 string and not bytes

    @steviez
    steviez committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    089c5c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Forgot to specify --output json

    @steviez
    steviez committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    ca7a098 View commit details
    Browse the repository at this point in the history

  2. Use quotation marks for jq query

    @steviez
    steviez committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    ddb78bb View commit details
    Browse the repository at this point in the history