Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ledger-tool: Make verify --print-bank-hash support json #1745
ledger-tool: Make verify --print-bank-hash support json #1745
Changes from all commits
8d2d1e1
2af3939
12faa6a
f0227cc
a99cd89
089c5c5
ca7a098
ddb78bb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you given any thought to how to handle once
shred_version
is also optionally printed? If a single, flat map, can be handled in later PR. If a nested map (eg.{"bankHash": {"slot": .. }, "shredVersion": .. }
), might be best to set that up here.Imo, flat map would be better, if it makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave a little thought, but couldn't think of a solution I loved. Conceptually, I think the types for
shred-version
andbank-hash
could/should be separate. But you're absolutely right that if I implementshred-version
in an identical manner, we'd print this non-ideal output:I probably prefer the flat-map as well, will have to take a sec to think about how to most cleanly do that