-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keygen] Remove deprecated functions from the grind
command
#490
[keygen] Remove deprecated functions from the grind
command
#490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits. It's too bad about the GrindMatch
parser, but I can't think of a better approach, given the clap api.
Co-authored-by: Tyera <teulberg@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #490 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 842 842
Lines 228436 228436
=======================================
+ Hits 186996 187008 +12
+ Misses 41440 41428 -12 |
Problem
The
solana-keygen
cli still has some deprecated functions from clap-v2 for thegrind
command logic.Summary of Changes
Removed deprecated functions from the
grind
command.I think most commits should be pretty straightforward except for f4aee92, which replaces grind validator functions with a united grind parser. It would be nice to implement a parser that returns a
GrindMatch
type directly so that we can runmatches.get_one::<GrindMatch>(...)
, but the parsing logic depends on theignore_case
argument, which makes this hard to do. I ended up just definingString
parser that executes the existing validation logic for grind arguments.This is a follow-up to #438.
Fixes #